Merged
Conversation
…s the Lumerical *.lsf script files and img_001.jpg be downloaded to be run after the Maxwell2D results are computed. The Maxwell2D project is generated from scratch
…s the Lumerical *.lsf script files and img_001.jpg be downloaded to be run after the Maxwell2D results are computed. The Maxwell2D project is generated from scratch
…s the Lumerical *.lsf script files and img_001.jpg be downloaded to be run after the Maxwell2D results are computed. The Maxwell2D project is generated from scratch
…s the Lumerical *.lsf script files and img_001.jpg be downloaded to be run after the Maxwell2D results are computed. The Maxwell2D project is generated from scratch
…s the Lumerical *.lsf script files and img_001.jpg be downloaded to be run after the Maxwell2D results are computed. The Maxwell2D project is generated from scratch
…downloads of the files as per lines 281-285. Updated with the new PyLumerical package. Also Readme has been updated
…downloads of the files as per lines 281-285. Updated with the new PyLumerical package. Also Readme has been updated
…downloads of the files as per lines 284-288, so please adapt these lines. Updated with the new PyLumerical package. Also Readme.rst has been updated
# Conflicts: # maxwell2d-lumerical/wf_ml_01_ion_trap_modelling.py
…be consistent with other examples
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
MaxJPRey
reviewed
Feb 9, 2026
MaxJPRey
reviewed
Feb 9, 2026
MaxJPRey
approved these changes
Feb 9, 2026
MaxJPRey
reviewed
Feb 9, 2026
Co-authored-by: Maxime Rey <87315832+MaxJPRey@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.